Skip to content

Text only edits to error message catalog (doc review) #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

MiriamScharnke
Copy link
Collaborator

First batch of error message review, including those edits that required no further code changes.

@MiriamScharnke MiriamScharnke added the documentation Improvements or additions to documentation label Jul 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.13%. Comparing base (c607360) to head (83eff3a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files          39       39           
  Lines        1292     1292           
=======================================
  Hits         1255     1255           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ccreutzi ccreutzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting change in mustHaveMessages.

MiriamScharnke and others added 2 commits July 26, 2024 10:21
Co-authored-by: Deborah Ferreira <[email protected]>
@MiriamScharnke MiriamScharnke merged commit ddcf6f1 into main Jul 31, 2024
1 check failed
@MiriamScharnke MiriamScharnke deleted the error-message-text-only-edits branch August 1, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants